Add a Cache.deleteStudent(username) method instead of using Cache.setStudent(username, null)

[abhijitparida]

File location: app/src/main/java/app/abhijit/iter/data/Cache.java

~(update/add unit tests accordingly)~

[jashasweejena]

I'd like to take this up!

[abhijitparida]

Alright! 🎉

[jashasweejena]

Do I need to modify only the implementation in data/Cache.java or do I need to modify the method uses too?

[abhijitparida]

You also need to change all the method calls. Bonus: add unit tests for the new method.

[jashasweejena]

You also need to change all the method calls. Bonus: add unit tests for the new method.

Never added a unit test myself. Could you walk me through briefly, if you don't mind? 😃

[jashasweejena]

Could I work on it at the night? if it's all good with you!

[abhijitparida]

I fixed the build config issue. Update your fork accordingly. I also recommend using different branches for each pull request. See: https://guides.github.com/introduction/flow/

Never added a unit test myself. Could you walk me through briefly, if you don't mind? 😃

Actually, I haven't set up tests for Cache yet. So you don't have to worry about that.

Here is an example unit test, for Subject: SubjectTest.java

Could I work on it at the night? if it's all good with you!

Take your time!

[jashasweejena]

Actually, I haven't set up tests for Cache yet. So you don't have to worry about that.

So I'd have to add tests for the entire 'Cache.java' if I'm not mistaken?

Here is an example unit test, for Subject: SubjectTest.java

Thank you!

Take your time!

Sure 😁

[abhijitparida]

No, you don't have to add tests for Cache.

[jashasweejena]

Okay. Thank you!

[jashasweejena]

No, you don't have to add tests for Cache.

So, all in all, I don't need to work with tests?

[abhijitparida]

No. Just ensure that the app builds successfully without any warnings/errors.

[pedroqueiroz]

Hi!

Is this issue taken by anyone?

Thanks! :)