bunk icon indicating copy to clipboard operation
bunk copied to clipboard

Add adaptive launcher icon

Open abhijitparida opened this issue 6 years ago • 10 comments

Source material:

  1. https://github.com/abhijitparida/bunk/blob/master/promo/logo.svg
  2. https://github.com/abhijitparida/bunk/blob/master/promo/playstore%20logo.png

abhijitparida avatar Oct 23 '18 10:10 abhijitparida

I would like to work on this :)

jashasweejena avatar Oct 23 '18 10:10 jashasweejena

Sure, go ahead! But please keep the existing launcher icons as they are.

abhijitparida avatar Oct 23 '18 10:10 abhijitparida

Sure, go ahead! But please keep the existing launcher icons as they are.

okay!

jashasweejena avatar Oct 23 '18 10:10 jashasweejena

Actually was facing a couple of issues, probably because I recently updated to the latest Android Studio 3.2. Could not find aapt2-proto.jar (com.android.tools.build:aapt2-proto:0.3.1). this is one of 'em. Fixed it by keeping google() above jcenter() on lines 6 in project level build.gradle. Should I make a separate PR for those? Another change I made was updated distributionUrl in gradle.properities to point to gradle version 4.10.2. Also there's a warning saying The specified Android SDK Build Tools version (27.0.3) is ignored, as it is below the minimum supported version (28.0.3) for Android Gradle Plugin 3.2.1. Android SDK Build Tools 28.0.3 will be used. What do I do about 'em? Thanks for your time 😃

jashasweejena avatar Oct 23 '18 11:10 jashasweejena

Make a separate PR.

abhijitparida avatar Oct 23 '18 11:10 abhijitparida

Make a separate PR.

Will one PR do? Or do I need to make more than one?

jashasweejena avatar Oct 23 '18 11:10 jashasweejena

Just one will do. Something like "Update build config for Android Studio 3.2".

abhijitparida avatar Oct 23 '18 11:10 abhijitparida

You might also have to modify .travis.yml if you are going to change the SDK Build Tools version.

abhijitparida avatar Oct 23 '18 11:10 abhijitparida

Just one will do. Something like "Update build config for Android Studio 3.2".

Just did one! Please check.

jashasweejena avatar Oct 23 '18 11:10 jashasweejena

You might also have to modify .travis.yml if you are going to change the SDK Build Tools version.

Oh. Android Studio didn't throw a warning or something tho!

jashasweejena avatar Oct 23 '18 11:10 jashasweejena