Kelly Kinkade

Results 116 comments of Kelly Kinkade

> There is a chance that we would need to put in some extra work to get SDL linking properly at build time for everyone, especially on Windows. I don't...

implementing this would require scanning not only the `SEEDS` category vector for actual seeds, but also the `PLANT` and `PLANT_GROWTH` vectors for plants and plant growths that, if processed, could...

i do not have a save, just a crash log and a dfhack stderr.log. my conclusion is that the building subcats vectors in `building_handlerst` can't be relied on to be...

Still crashes on Windows, while trying to display the splash image. Interestingly, on reload the plugin does _not_ attempt to reload the splash image; it uses the bitmap that was...

this appears to be because codegen generates lua metadata that identifies the field as a "pointer to a single character" instead of identifying it as a C-style string

further research: codegen emits this as `{ FLD(POINTER, name), identity_traits::get(), 0, 0 },`. it should be `{ FLD(PRIMITIVE, name), TID(char*), 0, 0 },` which would result in it being mapped...

> Regarding `std::unordered_map`, the keys (i.e., `first`) aren't accessible by Lua. Running `pairs` on it gives 0-n for keys and just the value of `second` for values (i.e., not `{first,...

> If nobody ever ends up needing it, then it'd be kind of pointless. (Bay12 might use the type eventually?) Bay12 is already using `std::map`s in several places (notably in...

Let me add here that this code is not really ready to go yet. I _really_ want to extend this to encompass `std::vector` which right now is still being handled...

> does this deserve a changelog line (probably under API)? lemme finish writing it first lol