Aymeric Augustin

Results 368 comments of Aymeric Augustin

@ximbled Russell pinged me on Twitter to ask my opinion. I wrote it. I didn't read previous comments. The reason why you engaged in a point-by-point rebuttal of my personal...

We could record how long it took to send the ping and reduce the wait accordingly. That would improve the behavior as long as sending the ping takes less than...

Your suggestion is also an option, however I don't like creating too many tasks at the library level. There's a long string of concurrency issues in this bug tracker... The...

See the second example here: https://docs.python.org/3/library/asyncio-task.html#asyncio.wait_for

> Is there any reason your "def ping" is making the pong_waiter "shielded" ? Yes. If a user of websockets awaits a coroutine that awaits pong_waiter, and then cancels that...

The idea of forking one task per ping is rejected. I filed #1240 for scheduling pings more accurately. I think that covers all the points discussed here.

In some scenarios, a TCP connection can hang and the OS doesn't know or gets stuck trying to close it while the other end no longer responds. In this case,...

> first websocket object is technically "deleted" I'm not sure the object is deleted just because you no longer hold a reference. It depends on the garbage collector's behavior. What...

Based on the user agent, compression errors happen on connections coming from Google Chrome. (Unless this is something else masquerading as Google Chrome?) I don't see how we could debug...

Regarding `AttributeError: 'Connection' object has no attribute 'transfer_data_task'`, this happens only if `WebSocketServerProtocol.close` (where the error happens in you stack trace) is called before `WebSocketServerProtocol.connection_open` (where the attribute is set...