Aymeric Augustin comments

Results 368 comments of


                                            Aymeric Augustin

Suggestion: a more robust implementation for the AUTOCOMMIT option & make it the default on Django ≥ 1.9

Here's a custom `Queue` class that implements the approach I described above. ``` python from django.db import transaction from rq.queue import Queue DEFAULT = object() class OnCommitQueue(Queue): """ RQ Queue...

Suggestion: a more robust implementation for the AUTOCOMMIT option & make it the default on Django ≥ 1.9

Note that this approach makes it impossible to return the job synchronously, since it isn't created until the database transaction commits and won't be created if the transaction fails.

Suggestion: a more robust implementation for the AUTOCOMMIT option & make it the default on Django ≥ 1.9

Congratulations :-) The custom `Queue` class works just fine for now, no hurry!

Is there any option to use custom action toolbar button?

Another use case: I use the `abbr`, `footnotes`, or `toc` extensions provided by the Python markdown package and I'd like to add a button to generate the corresponding markup.

Add `shared_db_wrapper` for creating long-lived db state

Django 1.6 and 1.7 don't receive security updates anymore. I don't think you should refrain from merging this feature just because it doesn't work on these versions. I suggest to...

Add `shared_db_wrapper` for creating long-lived db state

I'll try it in my current project and report back (hopefully today or tomorrow).

Add `shared_db_wrapper` for creating long-lived db state

I tried the patch and unfortunately I couldn't make it work. I'm getting two kinds of errors: - some tests fail, apparently because of isolation issues between tests -- which...

Add `shared_db_wrapper` for creating long-lived db state

I'm not comfortable with pytest's internal APIs, but the general scheme here should be: ``` python with transaction.atomic(): # run shared_db_wrapper fixtures for test in in tests: with transaction.atomic(): #...

Incompatible scopes of live_server and transactional_db

Nope. I'll report my findings here if I find time to work on a solution. It isn't near the top of my TODO list.

Incorrect timezone handling in feed community blog post aggregator

I hear Django got fancy timezones support a few releases ago :D