Aymeric Augustin
Aymeric Augustin
At first sight, I would do it in the Sans-I/O layer so all implementations benefit from it, to be confirmed after looking at feasibility.
Yes it makes sense to return 405 on anything that isn't a GET.
Thank you for reporting this problem. The error suggests a race condition between connection termination (when this code runs) and sending a ping or receiving a pong. I think there...
Yes, I agree, those are the main options to fix the problem, and a last option is to add a lock specifically for serializing operations on `pong_waiters` (because reusing `protocol_mutex`...
I ran your server and client (after changing the port to 8000 which is the default port for fastapi) and it works for me: ``` $ python client.py Message text...
I can see where you're coming from, even if I'm not a fan of such a flags (mostly because, once it exists, every StackOverflow answer starts recommending it as a...
Back when you submitted it, I noticed that the error message was getting heavy and repetitive. However, I didn't have an obvious idea to do better. Options include: - introducing...
Good catch, thank you. I think it wasn't there in the initial version, then got added later as a performance optimization. Yes it has the same semantics as in the...