Aymeric Augustin

Results 368 comments of Aymeric Augustin

Oops - forgot to merge this before releasing 10.4 :-( I'm going to merge it now.

This will be available in the next release. Please find the answer to your last question here: https://websockets.readthedocs.io/en/latest/faq/misc.html#are-there-onopen-onmessage-onerror-and-onclose-callbacks

That's the most reasonable way to do it for your use case that I can think of.

Yes, there should be a way to disable the User-Agent header -- probably with yet another keyword argument for `connect`, `serve`, `WebSocketClientProtocol`, and `WebSocketServerProtocol`.

Thanks for submitting the pull request! This gave me a solid basis for thinking about the best API here. (I care a lot about API design in websockets, sorry.) Let's...

Let's do that, then. If you want to update your PR and maybe take a stab at tests and docs, that's useful. Else, I can take it from there. Let...

Cool - go as far as you're interested and let me know when I can finalize and merge :-)

Still needs a test for the non-101 response path + docs.

Here's what I can infer from the stack trace. ``` future: ``` This is a task created by this code in `WebSocketServer.close()`: ```python close_tasks = [ asyncio.create_task(websocket.close(1001)) for websocket in...

Unclear that it's a bug after all.