Aymeric Augustin

Results 368 comments of Aymeric Augustin

Yes, that's what this issue is about — "fragmented messages" don't have the FIN bit set, except on the last frame.

If I understand your problem correctly, you may be able to solve it by passing a callable in the `extra_headers` argument. Then you can set appropriate response headers dynamically based...

If the `extra_headers` callable had access to the protocol instance — rather than just the request path and headers — then you'd be able to do what you want. Extensibility...

Right now my plan is to provide a better API when I rewrite an asyncio layer on top of the new Sans-I/O implementation.

Here's what I think is possible: - [ ] `path` is set (Unix socket connection): only same-origin redirects - [ ] `sock` is set (already connected socket): if the server...

Patch should look like: ```diff diff --git a/src/websockets/client.py b/src/websockets/client.py index 10435c1..a2a9f32 100644 --- a/src/websockets/client.py +++ b/src/websockets/client.py @@ -497,6 +497,16 @@ class Connect: old_wsuri.host == new_wsuri.host and old_wsuri.port == new_wsuri.port )...

Well, it looks like demand for this feature is low...

Probably the pragmatic solution is to disable all redirects when any of path, sock, host, or port is provided and wait until someone asks for allowing same-origin redirects.

Nice suggestions!

If I remember correctly Digest Authentication requires two HTTP requests: one to get the challenge from the server, one to send the response and open the websocket connection. If I...