Aaron Peterson
Aaron Peterson
Minor comment that the attaching implementation should probably be in `libcloudforensics` and referenced from the new pre-processor in Turbinia.
@hacktobeer Not really, this command will still generate a report output based on the current state of when it was called no matter if it's done or not. I guess...
Thanks @Igor8mr ! Let me know if you want any preliminary feedback, otherwise once you mark it as ready for review we can take a look.
Sounds good, thanks @Igor8mr and @jleaniz !
Cool, yeah looks good from a high level and I'll defer to @berggren on the more detailed review since I don't know Vue :) Thanks.
FYI @jleaniz
These are the same flags but to filter the list of requests and not statistics. I would like to be able to list only my requests or requests made in...
Minor comment that the attaching implementation should probably be in `libcloudforensics` and referenced from the new pre-processor in Turbinia.
FYI @Fryyyyy
I think most of the methods except `run()` are tested, so we might just want to mock the binaries and have a quick/easy test for that.