Aaron Peterson
Aaron Peterson
Yeah, general unit tests in this case. FWIW, I just checked, and the existing coverage is 26%. $ coverage run --source turbinia/ run_tests.py [... snip test output] $ coverage report...
Coverage has gotten better over time, but should still be higher (not sure what a good target number is). Currently have 54% coverage. ``` Name Stmts Miss Cover --------------------------------------------------------- turbinia/__init__.py...
FWIW, coverage is now a little over 60%, but I'd like it to be at 80% before closing this.
Currently at 69% coverage...
Not sure if this is really needed now as I believe we are hashing with Plaso but need to double check.
FYI @dfjxs
Changing this to deprecate PSQ as it is deprecated and will go away in the new architecture in favor of celery and api/web servers.
Some related links: https://zwischenzugs.com/2018/05/05/sandboxing-docker-with-googles-gvisor/ https://cloud.google.com/blog/products/gcp/open-sourcing-gvisor-a-sandboxed-container-runtime
FYI, I found other problems with the user attribute, so I filed https://github.com/google/turbinia/issues/359 (which also covers supporting this attribute in the Redis setup).
I suggest we add a flag for this (or possibly just show this extra information when `-a` is specified) in order to keep the output clean since the majority of...