turbinia icon indicating copy to clipboard operation
turbinia copied to clipboard

Published 20 hours ago • verified publisher icon google

Vue 2 to 3 migration

Open wajihyassine opened this issue 1 year ago • 6 comments

Description of the change

Migrates the Turbinia Web UI from Vue 2 to Vue 3

Applicable issues

  • fixes #1429

Additional information

Checklist

  • [x] All tests were successful.

wajihyassine avatar Feb 09 '24 22:02 wajihyassine

Web UI (Dark) web-dark

Web UI (Light) web-light

wajihyassine avatar Feb 12 '24 20:02 wajihyassine

Also @aarontp FYI for a high level look

wajihyassine avatar Feb 14 '24 16:02 wajihyassine

Filed https://github.com/google/turbinia/issues/1434 to update the documentation in a separate PR

wajihyassine avatar Feb 14 '24 16:02 wajihyassine

Thanks for rebuilding the UI Wajih. Looks great!

jleaniz avatar Feb 14 '24 16:02 jleaniz

Ack, I will review this next week.

berggren avatar Feb 17 '24 15:02 berggren

Cool, yeah looks good from a high level and I'll defer to @berggren on the more detailed review since I don't know Vue :) Thanks.

aarontp avatar Feb 17 '24 21:02 aarontp

@berggren friendly ping if you can PTAL this week even from high level that would be awesome hoping this can be in the next release

wajihyassine avatar Mar 06 '24 20:03 wajihyassine

Chatting out of band going to merge this so it makes it into the next release, can always patch if needed

wajihyassine avatar Mar 07 '24 18:03 wajihyassine