Adam

Results 337 comments of Adam

> But I still think that it would be better to have integrations with okio and kotlinx-io maintained in this repo. This would give us more insight on how good...

It should be possible to use JDK21 to run Gradle and compile the code (it doesn't have to be 21, but higher is better, because newer Java versions are faster...

However, Java 8 is ancient, so I don't feel very inclined to support it.

I've updated the config a bit, but we have a dependency on https://github.com/ethauvin/urlencoder, which requires Java 11. https://github.com/ethauvin/urlencoder/blob/dd3d500496b8768a89ff94d1cd0343e739a72940/buildSrc/src/main/kotlin/buildsrc/conventions/lang/kotlin-multiplatform-base.gradle.kts#L46-L50

hi @4o4E, I'd like to find out more about why you need Java 8. It's not so easy to support Java 8, because SnakeKMP has a dependency on a library...

Thank you both for investigating and explaining. I understand that the caches are saved 'per job', and I wonder how that works with re-usable workflows? [Kotest](https://github.com/kotest/kotest/) uses a re-useable workflow...

Would using the [concurrency group](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-concurrency#using-concurrency-in-different-scenarios) be possible, and useful? It's possible to encode all inputs of the workflow as a concurrency group using `${{ join(inputs.*) }}`. Example: https://github.com/adamko-dev/dokkatoo/blob/2d1e8902ce550c1df8bad9c2be540eb7e9258097/.github/workflows/run_gradle_task.yml#L37-L40

> Collisions would still occur if the same reusable workflow was invoked more than once with the same inputs. There would be a collision, but would it be a problem?...

Hey, thanks for raising this. I am very interested in improving performance and avoiding unnecessary downloading. However, I don't think using JetBrain's cache redirectors is a good idea. They aren't...

> Thanks for the feedback. Had selected the JetBrains mirror as a) am using it elsewhere and b) it's used farther down in that settings.gradle.kts for npm & yarn deps....