Adam
Adam
There have been a few relevant updates from KxS JSON that I think are worth considering when implementing an equivalent in json5k. I'm mentioning them because they might help guide...
hey @xn32, I've had a stab at a workaround, take a look at this commit: https://github.com/aSemy/json5k/pull/1/commits/467f4a1d15a8748a0e1b2911fc672b589657ac23 There are some minor cosmetic differences. Some scientific-notation numbers are formatted with a `.0`,...
Oh that's interesting, I thought that option 2 was already implemented. So this fails: ```kotlin println(Json5.decodeFromString("5")) // ERROR Uncaught Kotlin exception: io.github.xn32.json5k.UnexpectedValueError: floating-point number expected at position 1:1 ``` I...
Thanks! I'll try it out. Are snapshots published?
Good news: I've tried it out and I've got some basic tests that use JSON5 passing on both K/N and K/JS!
Nice! Thanks for making the list. ContinuallyTest should be fixed by #4109, which uses kotlinx.coroutines virtual time. I expect that the other tests could be fixed in the same way....
I think that when configuration cache is enabled `org.gradle.parallel` has no effect. Tasks from multiple projects will run in parallel. There are a few performance tests scattered about. TBH, I...
Quite a lot of the engine tests use `TestEngineLauncher#launch`, which uses `runBlocking {}`. I suspect this would be a cause of flaky tests, because the tests won't be able to...
Hmmm yes, that makes sense. I was asking because the GlobalTimeoutTest failure (added to the issue above) above indicates that the `global timeouts should apply if no other timeout is...
Another idea: tag add `@Tag("Deprecated")` to all tests of deprecated functionality and run them in a separate GitHub step. The deprecated tests are often more flaky, and we can either...