Adam

Results 337 comments of Adam

> Seems like we cannot proceed with tag-based exclusion due to #4135. Silver lining: It is good that we are finding bugs 🙃

Hmmm it looks like my workaround for GlobalTimeoutTest doesn't work reliably. There's a failure on Windows: https://github.com/kotest/kotest/actions/runs/9624071919/job/26547346172?pr=4141#step:7:2206 ``` > Task :kotest-framework:kotest-framework-engine:jvmTest com.sksamuel.kotest.engine.test.timeout.GlobalTimeoutTest[jvm] Test global timeouts should apply if no other...

Just a thought: is automatically using virtual time whenever `coroutineTestScope` is enabled a breaking change? Might it cause issues in user's code?

I think there are loads of good improvements, and this PR will absolutely improve the Kotest tests, but I'm not convinced that the non-deterministic test utils (`eventually`/`continually`/et al) should use...

Hmmmm JVM tests work, but WasmJS fails ``` ./gradlew :kotest-assertions:kotest-assertions-core:wasmJsTest --stacktrace [...] Disconnected (0 times) , because no message in 30000 ms. java.lang.IllegalStateException: command '/Users/dev/.local/state/gradle/nodejs/node-v22.0.0-darwin-arm64/bin/node' exited with errors (exit code:...

I found a similar issue on Slack https://slack-chats.kotlinlang.org/t/18859293/is-there-special-config-required-to-run-tests-with-wasmjs-i-, but the suggested workaround didn't help https://youtrack.jetbrains.com/issue/KT-67468

I got some help and we figured out the problem: the Kotest Gradle Plugin isn't applied to Kotest projects, so the tests can't be discovered or launched.

Thanks @OliverO2! However, the tests need `testCoroutineScheduler`, and I think this isn't available on Wasm yet? https://github.com/kotest/kotest/issues/4077

Related: https://github.com/kotest/kotest/issues/4066

Something that makes the amount of warnings more overwhelming is that if there is a warning in commonMain, then Kotlin prints the same warning for each target, and Kotest has...