Adam

Results 337 comments of Adam

Yes, that makes sense. But, now that I think about it, it would probably make more sense to generate a Dokka HTML site?

We could also consider excluding `kotlin.PublishedApi` from the ABI dump, since they're not really visible to users.

The config specifying Java 11 was already defined before I started updating the project to KMP :) https://github.com/ethauvin/urlencoder/blob/34b69a7d1f3570aa056285253376ed7a7bde03d8/lib/build.gradle.kts#L50-L54

It'd be nice to be able to build with Java 21, but set the Java target to 8, and then use Java 8 to run the tests. I've been trying...

Looks good to me 👍 If you will allow me to be a perfectionist though, I would recommend the following: - Hardcode Gradle to use a specific JDK for the...

> That, frankly, I don't care about. If curl was an option, I'd use it. Completely reasonable. My reasoning is because I prefer to use a few external dependencies as...

If the SnakeKMP tests pass with the snapshot version, then that's a very good indication 👍. I say go ahead with the 1.6.0 release.

I haven't looked at kotlinx-io at all, but I strongly suspect (since it's in alpha) it doesn't support all of the features that we use... yet.

> think it would be great to do something similar to what is done in kotlinx-serialization-json for okio and kotlin-io. I do like this idea, but I think it makes...