Amir Alavi
Amir Alavi
I'd like to take the pre-release code changes to become more familiar with the process. /assign
Yes, I saw your comment after the assignment. Makes sense 👍🏼
/unassign
Adding our discussion here as well for reference. Given that https://github.com/kubernetes/kubernetes/pull/111441 has been merged, Descheduler could use the new `MatchLabelKeys` field similar to how Scheduler is using it today. cc:...
@ingvagabund @damemi do you have any requests for changes on this PR?
@Dentrax can you rebase to get the latest? `corev1informers` and `schedulingv1informers` are no longer used.
/lgtm Thank you for your contribution 🏆
/ok-to-test I feel that `namespaceSelector` better aligns with existing Kubernetes resources. For example [Dynamic Admission Controller](https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#matching-requests-namespaceselector). /cc @knelasevero and @ingvagabund thoughts?
Hi @chaunceyjiang , does the example mentioned in the linked issue help? https://github.com/karmada-io/karmada/issues/4681#issuecomment-1980025646