Amir Alavi

Results 47 issues of Amir Alavi

*Issue #, if available:* *Description of changes:* Provide the ability to pass in the ceiling for max-pods instead of relying on the default values for low/high cpu count. By submitting...

/cc @jklaw90 @damemi In order to improve our observability/monitoring, we would like to include certain pod labels in our metrics. use-cases: 1. We have compliance tags to identify cost-center/teams/projects (e.g....

cncf-cla: yes
size/L
do-not-merge/work-in-progress
needs-rebase
ok-to-test

**What version of descheduler are you using?** descheduler version: v0.24.0 `nodeFit` flag does make much sense in the following strategies: 1. `RemovePodsViolatingTopologySpreadConstraint` - This strategy calls `nodeutil.PodFitsAnyOtherNode` twice. Once when...

kind/bug

Request to add support for [MinDomains](https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3022-min-domains-in-pod-topology-spread) being added to TopologySpreadConstraint. Ideally we would simply use MinDomains (when specified) instead of the length of topology domains [here](https://github.com/kubernetes-sigs/descheduler/blob/b2418ef481298c6caf185a5f88dd0bb6ddc1cdbf/pkg/descheduler/strategies/topologyspreadconstraint.go#L256) and potentially other places...

kind/feature
lifecycle/frozen

**Is your feature request related to a problem? Please describe.** Currently, RemovePodsViolatingTopologySpreadConstraint requires PodTopologySpread to be defined on every Pod. This can be challenging for organizations that already have thousands...

kind/feature

## Proposed Changes * components such as `controller`, `autoscaler` use the selector label `app` while `webhook` and `domainmapping-webhook` use the `role` selector. This change includes the `app` label which brings...

size/XS
ok-to-test

**Describe the bug** `knative-eventing-controller` ClusterRole is overly permissive. For example, why does knative-eventing require the deletion of `events` or `namespaces`? https://github.com/knative/eventing/blob/db235e7b704c37b5e64cd1a62b5760b3829507ff/config/core/roles/controller-clusterroles.yaml#L26-L42 **Expected behavior** Reduce permissions to only require what is...

kind/bug
triage/accepted

Rationale: 1. e2e tests are not executed against a Descheduler install. If anything, we could end up with a race condition between a Descheduler run and the e2e tests. For...

cncf-cla: yes
size/XS
lgtm
approved
needs-rebase

In PR https://github.com/kubernetes-sigs/descheduler/pull/945 the helm e2e failed and I observed the following: 1. slash commands don't work (e.g. `/retest`) 2. I don't have permission to restart the build We can...