Amir Alavi comments

Results 236 comments of


                                            Amir Alavi

set `karmada.io/managed` label to all credentials resources

@XiShanYongYe-Chang no rush, but should be ready for your review

Bump google.golang.org/protobuf from 1.32.0 to 1.33.0

any updates on this PR?

build(deps): bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from 0.35.1 to 0.44.0

/retest

build(deps): bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from 0.35.1 to 0.44.0

Library Vulnerabilities: | Severity | CVE | Package Name | Current Version | Fixed Version | Source | |------------|---------------------|-----------------------------------------------------------------------------|-------------------|-----------------|---------------------------------------------------| | HIGH | CVE-2023-47108 | go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc | 0.35.0 | 0.46.0 |...

build(deps): bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from 0.35.1 to 0.44.0

> Prometheus-adapter is not impacted by these since it does't use the otel server nor it is exposing any otel metrics. That said, I am fine with updating the deps...

build(deps): bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from 0.35.1 to 0.44.0

This requires a bump from [custom-metrics-apiserver](https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/master/go.mod#L72) first

Add annotation to the the resource template to prevent removal managed resources

👋🏼 happy to contribute if I can push this forward (design or implementation)

fix: retain `PersistentVolumeClaim` annotation `volume.kubernetes.io/selected-node`

/remove-hold

fix: retain `PersistentVolumeClaim` annotation `volume.kubernetes.io/selected-node`

/retest-required

fix: retain `PersistentVolumeClaim` annotation `volume.kubernetes.io/selected-node`

/assign @rainbowmango