descheduler icon indicating copy to clipboard operation
descheduler copied to clipboard

run: `gofumpt -w -extra .`

Open Dentrax opened this issue 2 years ago • 6 comments

Enable gofumpt in golangci

Signed-off-by: Furkan [email protected]

Dentrax avatar Sep 30 '22 12:09 Dentrax

Hi @Dentrax. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 30 '22 12:09 k8s-ci-robot

/ok-to-test

a7i avatar Sep 30 '22 12:09 a7i

I can see a few other sigs projects are using gofumpt 👍🏼 /lgtm

a7i avatar Sep 30 '22 13:09 a7i

lgtm, but could we add it to the makefile so people can easily update when their PRs fail?

Make sense! Added make fmt and updated the doc.

Dentrax avatar Sep 30 '22 21:09 Dentrax

@Dentrax sorry for the delay on this PR. would you please rebase so we can move forward on the review?

a7i avatar Nov 01 '22 20:11 a7i

Rebased.

Dentrax avatar Nov 07 '22 06:11 Dentrax

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 07 '22 13:11 k8s-ci-robot

/lgtm

a7i avatar Nov 08 '22 18:11 a7i