Mauryan Kansara

Results 200 comments of Mauryan Kansara

Fix is merged: https://github.com/checkstyle/checkstyle/pull/15580

PR sent regarding updating coverage table to mention the defect in our config: https://github.com/checkstyle/checkstyle/pull/15417

> I need your help to play around with this and test it on few inputs. Gotcha. I will look into this issue once I get some free time from...

> To enforce `{` in `case / default` to be on its own line I think we can try to add additional configuration with `LeftCurly` check. For LITERAL_CASE and LITERAL_DEFAULT...

@rdiachenko I tried your suggestions and here are the results: ```xml ``` ```java $ cat .\Test.java public class Test { { // false-negative System.out.println("Testing"); } { System.out.println("Testing"); } int bbb...

> We don't introduce false positives by doing this. Having false negatives is ok. These cases still need to be covered, but we can do it as a separate task...

PR sent https://github.com/checkstyle/checkstyle/pull/15724 @rdiachenko

> If valid, it looks like a scope issue and not a check issue. > > Issue does not mention this is connected to Google style and does not list...

yes private classes are excluded, only public classes are considered, specifically only their public and protected members are considered. I have updated the example in the description, explaining where warnings...

@romani I was trying to check that how to detect protected methods for public classes. In MissingJavadocType, `scope` is set to `protected` to detect missing javadoc for public and protected...