Mauryan Kansara
Mauryan Kansara
> We need formatter to be happy Just clearing my doubt, are we going to follow google-java-format's formatting? User provided code wasn't compliant with formatter.
I see that no google IT tests are modified and the regression project file contains only 2 projects, they were only for google style. If google style is not our...
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/8317a022124857fced6f64f7b0fee9542188c117_2025014908/reports/diff/hibernate-orm/index.html#A5 why we have duplicate violations for the same line? @mohitsatr @romani
Do not close the PR, we'll do it once we validate all the changes in diff
@mohitsatr Did you confirmed the code using google-java-formatter? If yes then please show it here, then we can treat this issue as "google-style" related.
> just so that I understand, does that mean that only behavior that deviates from the `google-java-format` tool is buggy? @s-ste, as @mohitsatr said at https://github.com/checkstyle/checkstyle/issues/17122#issuecomment-2924192405 > Google-style does not...
@mohitsatr any update on this?
Yes. If we need violation and formatter complains for it then we need to exclude that file and make InputFormatted file for it so formatter can be happy.
We should fix error for pgjdbc @mohitsatr https://app.circleci.com/pipelines/github/checkstyle/checkstyle/34516/workflows/55b21dae-ed5c-457a-8f14-d5b149bfb09f/jobs/973041
@romani can you restart CI?