Mauryan Kansara

Results 200 comments of Mauryan Kansara

> https://github.com/checkstyle/checkstyle/tree/master/src/test this is testing of each module (checks, filters ) completely independently. Inputs covers all possible permutations of Check properties. > > https://github.com/checkstyle/checkstyle/tree/master/src/it/java/com this is testing of config file...

> `it` means "integration tests", it is not a unit test, integration means combination of multiple. In this case it is combination of Check+XpathFilter. In this filter we are testing...

Closing this issue, reason mentioned here: https://github.com/checkstyle/checkstyle/issues/14938

> @Zopsss , > > please show result of `java -jar checkstyle-10.12.7-all.jar -c /google_checks.xml src/Test.java` to make sure there is no violations from other Check. Google style coverage is done...

Hey @romani I was thinking about starting working on this issue. The check's mostly logic is contained only in one method: https://github.com/checkstyle/checkstyle/blob/e6518fb9bfd27206e6c42e863f2859373546e8da/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/OverloadMethodsDeclarationOrderCheck.java#L101 this same logic but with few modifications can...

@nrmancuso so should I open a new issue for the discussion about adding constructor support for `OverloadMethodsDeclarationOrder`, I will link my PR to that issue and when that PR gets...

hey @nrmancuso I have created a new [issue](https://github.com/checkstyle/checkstyle/issues/14415) as you suggested, can you check that out?

> Let’s edit this issue description to just have the premise that the Google style guide says that constructors should be ordered as such, but google_checks.xml shows no violations for...

fix is merged by: https://github.com/checkstyle/checkstyle/pull/14921