Lukas Heumos

Results 522 comments of Lukas Heumos

Maybe @Koncopd has a comment here, too?

Sure! So almost all (we're catching up at the moment) of our core packages use https://github.com/scverse/cookiecutter-scverse as the basis for their package. It'd be awesome if you could recreate scvi-tools...

I won't have the bandwidth to work on this feature for a while, but I'm open to accepting PRs from anyone interested in implementing it.

@wassmi would you be willing to file a PR to suggest some improvements, please? Note that we ideally don't have super verbose parameter descriptions as some functions already have big...

I don't understand why we would add a GHA workflow instead of just adding mypy to the pre-commit config. The latter should suffice. I also suggest that we put the...

Thank you very much for the detailed issue! It'll take a while for me to have a look but I totally see your need. I'm not sure yet what the...

I'll have a look at this next week, sorry.

Eieiei this PR is still open. I'll finalize and merge this in about 10 days. Sorry!

https://github.com/scverse/pertpy/pull/874/commits/8bc7e4e79a70aef5d3fa4d6393fe043b6bca16e6 like this or?

I'm looking into it. I changed the default from pydeseq2 but we're passing 'edger' explicitly as solver there. I'll figure it out and merge then.