Youssef Victor

Results 911 comments of Youssef Victor

~~The tests that are failing in CI are passing locally for me~~ ![image](https://user-images.githubusercontent.com/31348972/190198195-e7058391-b0a2-4357-aa22-30683f4dcb39.png) ~~Probably it's worth another restart?~~ Ops, sorry, was on different branch. Will re-test

Confirmed test failures happen locally. Will take a look to try understanding what's happening.

![When_Composite_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics_Automated](https://user-images.githubusercontent.com/31348972/190241797-494a9b0b-8b58-4ea9-8227-105aff1f6a89.png) ![When_Composite_When_Composite_-_Tear_down_on_error](https://user-images.githubusercontent.com/31348972/190241826-df3eae34-7d28-43af-9709-d4636854c39c.png) There is a small shift somewhere between the two images (I got one from passing CI on master and one from CI in this PR), though it's hard...

I guess I understand what's happening now. There is an empty `TextBlock` below the one that reads "DESCRIPTION" which used to have a height, but it's now zero height. It...

I hope it passes this time :)

@jeromelaban This is ready for review.

I think the top contributor to the allocations here is https://github.com/dotnet/roslyn/issues/64142 In Uno, `GetTypeByMetadataName` is called a lot, and with types that don't exist (part of this is by-design), and...

https://github.com/unoplatform/uno/blob/92bd1e47034a5cb879b6e3201cd56bf067f50807/src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/TextBlockControl/TextBlock_Hyperlink.xaml#L80 ![image](https://user-images.githubusercontent.com/31348972/187835293-5c027d95-7177-475d-b9c8-921a965874cb.png) Looks like it's working now? @sakshi173 Can you confirm?

The `This paragraph contains an hyperlink that wraps over multiple lines, surrounded by regular text.` one is probably missing an underline for part of the hyperlink.

@jeromelaban Is it safe to remove the hash part if things paas?