Youssef Victor
Youssef Victor
> I believe when I was working on the PR to recover the dropout samples, I've removed the tag number from the snippet reference but probably forgot to remove the...
@mairaw, Missed this. Yes, both are used in the same xml file in dotnet-api-docs. I couldn't find other usage for any of them. But I prefer that you double-check. ---...
@jeromelaban Looks like this is already fixed
@jeromelaban This is ready for review now.
> Would be nice to find a way to test this automatically. Bugs or regressions in this code could potentially become very expensive and difficult to diagnose. In what way...
@carldebilly Can you check the way I'm testing this? Obviously the current tests are not enough, I'll expand them, just asking about the how you like the approach :) Note...
Pinging @carldebilly @jeromelaban for review.
> An intermediate change would be to use the generator for types inside of Uno only, and make the virtual method private protected. That would be a breaking change too...
- I made it `private protected`, not sure if that's enough @jeromelaban - CI is failing with: `Removed method Uno.UI.Xaml.RoutedEventFlag Windows.UI.Xaml.Controls.Control.GetImplementedRoutedEvents(System.Type type) not found in ignore set.`, but I added...
> The generator will try to be executed in apps, which won't have access to the base for the generated method. This shouldn't happen since I have: ```csharp if (!getImplementedRoutedEventsSymbol.ContainingAssembly.IsSameAssemblyOrHasFriendAccessTo(context.Compilation.Assembly))...