uno icon indicating copy to clipboard operation
uno copied to clipboard

Add support for `Hyperlink` on Skia

Open sakshi173 opened this issue 4 years ago • 9 comments

Current behavior

Hyperlink in TextBlock is not supported on Skia targets. This is due to the fact that GetCharacterAt method is not supported.

HP issue

Expected behavior

"Uno Platform" should display and work as hyperlink.

How to reproduce it (as minimally and precisely as possible)

  1. Launch the Uno.Gallry app on Skia.GTK
  2. Click on “HyperlinkButton” option from the list.
  3. Observe "Uno Platform" is not displaying as hyperlink and not working as hyperlink when clicking it.

Nuget Package: Uno.UI.Skia.Gtk

Affected platform(s): GTK (Linux)

IDE: Visual Studio 2019 (version: )

sakshi173 avatar Feb 09 '21 15:02 sakshi173

Hyperlink is working for HyperlinkButton, But issue is still present for Official documentation and due to that reopening the issue. office documentation issue

sakshi173 avatar Mar 19 '21 01:03 sakshi173

Hyperlink is working for HyperlinkButton, But issue is still present for Official documentation and due to that reopening the issue. office documentation issue

sakshi173 avatar Mar 22 '21 20:03 sakshi173

Still the hyperlink is not working for official Documentation

Hyperlink issue

sakshi173 avatar Aug 09 '21 18:08 sakshi173

The issue is currently the fact that Hyperlink within TextBlock on Skia is not supported. Changed the title accordingly.

MartinZikmund avatar Feb 02 '22 12:02 MartinZikmund

https://github.com/unoplatform/uno/blob/92bd1e47034a5cb879b6e3201cd56bf067f50807/src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/TextBlockControl/TextBlock_Hyperlink.xaml#L80

image

Looks like it's working now?

@sakshi173 Can you confirm?

Youssef1313 avatar Sep 01 '22 05:09 Youssef1313

The This paragraph contains an hyperlink that wraps over multiple lines, surrounded by regular text. one is probably missing an underline for part of the hyperlink.

Youssef1313 avatar Sep 01 '22 05:09 Youssef1313

The This paragraph contains an hyperlink that wraps over multiple lines, surrounded by regular text. one is probably missing an underline for part of the hyperlink.

@sakshi173 can you open an issue specifically for this?

jeromelaban avatar Sep 01 '22 12:09 jeromelaban

@jeromelaban, sorry I didn't get it exactly, but now the issue is the link Official Documentation is missing for WASM and Skia.Gtk and I can raise a separate issue for that, please let me know your views.

sakshi173 avatar Sep 12 '22 17:09 sakshi173

@sakshi173 Actually, let's keep as is in this issue, after looking again at the issue.

jeromelaban avatar Sep 12 '22 19:09 jeromelaban

image

This is now working!

MartinZikmund avatar Jun 01 '23 09:06 MartinZikmund