Youssef Victor
Youssef Victor
@jeromelaban Could you restart the failing checks? Thanks!
@jeromelaban There are remaining failures here :(
@jeromelaban There are remaining failures here. Can you restart once again please? I hope this is ready to merge after that. Thanks!
@jeromelaban This is green now! 🎉
@jeromelaban Is this ready to merge?
I think we should never need `DependenciesInitializer` actually. I'll see how this can be improved. One possible challenge is that Uno.UI.SourceGenerators is consumable via Uno.UI package and also via `ProjectReference`s...
This doesn't seem to improve performance.
Consider removing this in the next major release: https://github.com/unoplatform/uno/blob/4666c66d75ea47c9156ea79c5d1e83465fdf570d/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlCodeGeneration.cs#L871-L873
Also https://github.com/unoplatform/uno/blob/master/src/Uno.Foundation/HResult.cs I think it should be removed. It's unused, and https://docs.microsoft.com/en-us/uwp/api/windows.foundation.hresult?view=winrt-22621 says: > When programming with .NET, this class is hidden GitHubuno/HResult.cs at master · unoplatform/unoBuild Mobile, Desktop and...
It might also be a good idea to not expose `HtmlImage` publicly https://github.com/unoplatform/uno/blob/88d7a4024ccdcaa07a6b8cd056ba55ef4e92865e/src/Uno.UI/UI/Xaml/Controls/Image/Image.wasm.cs#L17-L22 It should be used only by Uno, I think