samples icon indicating copy to clipboard operation
samples copied to clipboard

Duplicated files

Open Youssef1313 opened this issue 6 years ago • 4 comments

File 1: https://github.com/dotnet/samples/blob/master/snippets/csharp/VS_Snippets_Remoting/Classic%20WebServiceBindingAttribute.Location%20Example/CS/sourcecs.asmx

File 2: https://github.com/dotnet/samples/blob/master/snippets/csharp/VS_Snippets_Remoting/Classic%20WebServiceBindingAttribute.WebServiceBindingAttribute3%20Example/CS/sourcecs.asmx

Also it doesn't render correctly in the Live dotnet api docs

The article .md file refers to the snippet1 in that file, however, all the file is rendered even with the // <Snippet1> comment. The code snippet is also not colored properly.

Screenshot: image

Should the // <Snippet1> comments be removed like the #1060 PR done by @mairaw ?

Youssef1313 avatar Sep 01 '19 05:09 Youssef1313

I've reported this issue internally a long time ago but it hasn't been picked up yet. See context at https://github.com/dotnet/dotnet-api-docs/issues/798#issuecomment-404755734

I believe when I was working on the PR to recover the dropout samples, I've removed the tag number from the snippet reference but probably forgot to remove the snippet tag from the sample as I did to others in https://github.com/dotnet/samples/pull/1060.

mairaw avatar Sep 06 '19 08:09 mairaw

I believe when I was working on the PR to recover the dropout samples, I've removed the tag number from the snippet reference but probably forgot to remove the snippet tag from the sample as I did to others in #1060.

Opened https://github.com/dotnet/samples/pull/1428 for it.

Youssef1313 avatar Sep 06 '19 09:09 Youssef1313

Are both being used @Youssef1313?

mairaw avatar Oct 01 '19 03:10 mairaw

@mairaw, Missed this. Yes, both are used in the same xml file in dotnet-api-docs. I couldn't find other usage for any of them. But I prefer that you double-check.


(This issue can be transferred to docs or dotnet-api-docs repo, because you keeping issues in samples for dependabot)

Youssef1313 avatar Jan 02 '20 13:01 Youssef1313