Yeregorix
Yeregorix
I'm skeptical about using a callback instead of the blockchange event. Also, the code is duplicated and doesn't even build.
As I stated on the issue, the API already has everything needed, the real work is on the implementation.
PushReaction is not a StringRepresentable in MC internals. Do we want it to be StringRepresentable in our API? The rest LGTM.
`ItemActionEffect` sounds a bit redundant to me. Wouldn't `ItemAction` or `ItemEffect` be enough? I have a slight preference for `ItemAction` as it is easier to distinguish from `PotionEffect`.
Well, that's just my opinion, I'm not 100% sure
Merged by 34622032e7bda623d9eff36cd00e7d1503cb2af6
About the snakeyaml issue: servercore ships snakeyaml 2.2 sponge ships snakeyaml 1.28 This is likely what cause the error. A temporary workaround is to remove the `snakeyaml` entry in `sponge-libraries.json`...
Fixed compat with MrCrayfishFurnitureMod-Refurbished. Identified other problems: - Script `kubejs/startup_scripts/CustomAdditions.js` `StartupEvents.registry('block', ...)` causes the server to hang. - AllTheLeaks does a cast to `EventBus` too : https://github.com/pietro-lopes/AllTheLeaks/blob/c5b2015dab3b3ff84797e8c91caa1c0c87657a46/src/main/java/dev/uncandango/alltheleaks/leaks/common/mods/neoforge/Issue1486.java#L36
Identified a client error during login : ``` [14Feb2025 20:03:51.496] [Render thread/ERROR] [net.neoforged.neoforge.network.handlers.ClientPayloadHandler/]: Failed to handle registry sync from server. java.lang.NullPointerException: null at MC-BOOTSTRAP/[email protected]/com.google.common.collect.Iterators$6.transform(Iterators.java:829) ~[guava-32.1.2-jre.jar%23124!/:?] at MC-BOOTSTRAP/[email protected]/com.google.common.collect.TransformedIterator.next(TransformedIterator.java:52) ~[guava-32.1.2-jre.jar%23124!/:?] at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)...
AllTheLeaks 0.1.15 fixed.