Yeregorix

Results 17 comments of Yeregorix

I have now replaced all `printStackTrace` except in test sourcesets, and except in `SpongeWorldManager` because it will be fixed by PR #3702.

From a developer point of view, I prefer each class having its own logger. From a server owner pov, it's easier to identify which mod is involded when you see...

Yes, I'm just opposing the pros and cons of each convention.

For the moment, for each class I used the common logger if I saw that it was already used in the class, otherwise I used a specific logger.

There is no config to fully disable SpongeForge. The only correct way to do that is to remove the corresponding jar in the mods folder. If you can't remove the...

Crash can be fixed by splitting our `Mob#doHurtTarget` overwrite into smaller injections but many functionalities remain broken. A better fix may be to split our `Player#attack` overwrite too but that's...

Instead of having : `EngineConnectionState` `EngineConnectionIntentState` `EngineConnectionLoginState` `EngineConnectionConfigurationState` `EngineConnectionGameState` Shouldn't we have : `EngineConnectionState` `EngineConnectionState.Intent` `EngineConnectionState.Login` `EngineConnectionState.Configuration` `EngineConnectionState.Game` ? Same for `ClientConnectionState` and `ServerConnectionState`. Also why have `EngineConnectionStates` (all the...