Hauru

Results 32 comments of Hauru

在磁盘容量满时,用info命令查看会有报错: ![de5e2dc5885d3fbdf9fa5d458f93d27](https://github.com/OpenAtomFoundation/pika/assets/85615957/569f82ee-4194-4ba1-bbb5-56565febcfbd) 清理部分数据后还是会有报错 但使用flushdb或flushall命令清除,错误消失: ![912e7494811b22d151cfc9165ad7d77](https://github.com/OpenAtomFoundation/pika/assets/85615957/8fa4c963-7f0e-4187-b59d-6a664a96c027)

当前rocksdb中,默认情况下在写操作中任何一个错误(写WAL,Memtable落盘)都会导致db实例进入只读模式,之后的用户写操作都不会被接受。https://github.com/facebook/rocksdb/wiki/Background-Error-Handling 所以在磁盘容量满之后,底层rocksdb会触发错误导致进入只读模式,因此提出以下方案: 在辅助线程PikaAuxiliaryThread中增加定时容量检查,当磁盘清理后,剩余容量超过某一阈值时,进行`DB::Resume()`操作。 所以会引出两个问题:1.磁盘剩余容量阈值设置为多少比较好?2.多久检查一次剩余容量比较好?

@LiuYuHui Hi, how's it going now?

I'll do this, and will propose a solution later.

Thank you for your contribution! Maybe you need to add a command parser to use the data structure with actual command like redis.

> Also wondering does anyone know why the linting check couldn't pass as shown with errors (https://github.com/Beihao-Zhou/kvrocks/actions/runs/9052637137/job/24870567712#step:7:1493). @Beihao-Zhou The PR #2276 modified the variable name and the clang-tidy told you...

Is there anything we should pay special attantion to? @git-hulk @PragmaTwice @mapleFU @torwig

> Hi @Yangsx-1, thanks for creating the tracking issue. > > It would be nice if you create an issue per every command and make a list of these issues...

> Oh, but if you think that, like, there are a group of commands whose implementation code is closely connected and is not possible to assign each part to different...