kvrocks
kvrocks copied to clipboard
Tracking issues: add the support of all missing commands in the stream type
Search before asking
- [X] I had searched in the issues and found no similar issues.
Motivation
This issue considers to implement all missing commands like redis stream.
Already implemented commands:
XADD, XDEL, XLEN, XINFO STREAM, XRANGE, XREVRANGE, XREAD, XTRIM, XSETID
redis 5.0.0
consumer group:
XACK, XCLAIM, XGROUP CREATE, XGROUP DELCONSUMER, XGROUP DESTROY, XGROUP SETID, XPENDING, XREADGROUP
info:
XINFO CONSUMERS, XINFO GROUPS
redis 6.2.0
XAUTOCLAIM, XGROUP CREATECONSUMER
We can implement these commands through 3 stages:
1.Implement create, delete and simple comsume operations: XGROUP CREATE, XGROUP DESTROY, XREADGROUP
2.Implement critical operations: XACK, XPENDING, XCLAIM, XINFO CONSUMERS, XINFO GROUPS
3.Implement other operations: XGROUP CREATECONSUMER, XGROUP DELCONSUMER, XAUTOCLAIM, XGROUP SETID
Solution
- [x] #1586
- [x] #1588
- [x] #1730
- [x] #1731
- [x] #1732
- [x] #1733
- [x] #1734
- [x] #1735
- [x] #2181
Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
Is there anything we should pay special attantion to? @git-hulk @PragmaTwice @mapleFU @torwig
Hi @Yangsx-1, thanks for creating the tracking issue.
It would be nice if you create an issue per every command and make a list of these issues in this issue.
Hi @Yangsx-1, thanks for creating the tracking issue.
It would be nice if you create an issue per every command and make a list of these issues in this issue.
OK! I'll create some issues for commands in stage1. :)
Oh, but if you think that, like, there are a group of commands whose implementation code is closely connected and is not possible to assign each part to different people for implementation, in that case, you can simply open one issue for the group of commands.
Oh, but if you think that, like, there are a group of commands whose implementation code is closely connected and is not possible to assign each part to different people for implementation, in that case, you can simply open one issue for the group of commands.
That would be nice.
@Yangsx-1 Hello, are you planning to implement these commands on your own? I am a beginner, but I am very interested in this. I'm wondering if I can participate. Thank you!
@Yangsx-1 Hello, are you planning to implement these commands on your own? I am a beginner, but I am very interested in this. I'm wondering if I can participate. Thank you!
Thank you for your interest! I'm now doing issue #1586 . You can leave a comment in issue #1588 if you want to participate. #1586 is a prerequisite for #1588 . You can research it first and implement it after i finish #1586 . Good luck. :)
@Yangsx-1 Hello, are you planning to implement these commands on your own? I am a beginner, but I am very interested in this. I'm wondering if I can participate. Thank you!
Thank you for your interest! I'm now doing issue #1586 . You can leave a comment in issue #1588 if you want to participate. #1586 is a prerequisite for #1588 . You can research it first and implement it after i finish #1586 . Good luck. :)
Nice! Thank you so much!
Hi @Yangsx-1 , these issues seem interesting, Can I pick up any issue that you need a hand on / are independent of other issues?
Hi @Yangsx-1 , these issues seem interesting, Can I pick up any issue that you need a hand on / are independent of other issues?
You can pick any issue you like, and refer to #1654 for design. @uds5501