YYTVicky

Results 7 comments of YYTVicky

Hi, the for PBEParameterSpec, the iteration count should be large then 1000 for security reasons, so we recommend you use a number larger than 1000 when setting DEFAULT_ITERATION_COUNT = 17...

Hi, we found the TLS is not secure for build connection (https://www.packetlabs.net/tls-1-1-no-longer-secure/), would you mind changing it to TLSv1.3 for security concern?

Hi, could I know why my PR didn't pass the checks, the PR is a comment. Our tool report that keeps checkClientTrusted and checkServerTrusted empty body is not secure. Thanks!

Hi, we commend the key should be random generated for security reason, we have a recommend code patch: SecureRandom random = new SecureRandom(); String key= String.valueOf(random.nextInt()); byte[] key = defaultKey.getBytes();...

Hi The point I want to raise here is that maybe we can leave a template on the comment to help the user to implement it when using it (e.g.add...

Hi, Thanks a lot for your kind feedback. Since our tool only detects the API invocation with an insecure parameter, it will recommend the suggestions. Currently, it not able to...

Hi, I am not sure why the PR does not pass the test, I try to leave a comment in your file to avoid the test fail issues. But since...