kafka icon indicating copy to clipboard operation
kafka copied to clipboard

uggest change for security concern

Open YYTVicky opened this issue 4 years ago • 1 comments

More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.

Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

YYTVicky avatar Mar 06 '20 04:03 YYTVicky

Hi, we commend the key should be random generated for security reason, we have a recommend code patch: SecureRandom random = new SecureRandom(); String key= String.valueOf(random.nextInt()); byte[] key = defaultKey.getBytes(); key = Arrays.copyOf(keyBytes,24); Hope it can helps and looking forward to hearing any feedback from you!

YYTVicky avatar Apr 30 '20 01:04 YYTVicky