logging-flume icon indicating copy to clipboard operation
logging-flume copied to clipboard

add a comment to warn that it is not secure

Open YYTVicky opened this issue 4 years ago • 3 comments

YYTVicky avatar Mar 01 '20 02:03 YYTVicky

Hi,

could I know why my PR didn't pass the checks, the PR is a comment. Our tool report that keeps checkClientTrusted and checkServerTrusted empty body is not secure.

Thanks!

YYTVicky avatar Apr 30 '20 01:04 YYTVicky

Hi @YYTVicky ,

Thank you for this PR!

I think that was an issue with the build with all pull requests failing at that time. Can you please rebase your PR on master HEAD? The "Update branch" button should be sufficient.

bessbd avatar Apr 30 '20 17:04 bessbd

When I try to apply this patch I am getting merge conflicts. I don't there actually are any, just that the fork needs to be brought up to date. Can you please do this?

rgoers avatar Oct 08 '22 04:10 rgoers