Matthias Pohl
Matthias Pohl
> In https://github.com/apache/flink/pull/21971 we added SequenceGeneratorTest, I think we can add the corresponding test method in https://github.com/apache/flink/pull/21971 I'm not a big fan of adding tests that belong in a PR...
Any updates on that one @xuzhiwen1255 ? :slightly_smiling_face:
No worries. Especially considering that I won't be that responsive in September in general. I just wanted to let you know to make prioritization of work easier for you.
Thanks for the review @jiangxin369 and for the approval @snuyanzin . I'm gonna merge this one. The [failure](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=56466&view=logs&j=9cada3cb-c1d3-5621-16da-0f718fb86602&t=c67e71ed-6451-5d26-8920-5a8cf9651901&l=20767) is caused by FLINK-34077 and, therefore, unrelated. I verified that the one...
That's a fair point. I will mentioned that in FLINK-34498. :+1:
I updated the PR but will wait till tomorrow with switching it from draft back to reviewable state. I want to wait for CI to pass before it makes sense...
I looked into the missing synchronization for the `FineGrainedSlotManager#started` field: AFAIU, we're relying on all the methods which touch `#started` to run in the same thread (which is the `ResourceManager`'s...
Most-recent force push was a rebase to include fixes on master.
Rebased the branch to most-recent `master`. There was a conflict reported due to the upgrade of the mongodb connector (v1.0 to v1.1) which is now addressed in this PR.