Matthias Pohl

Results 122 comments of Matthias Pohl

Thanks for your contribution @zhoulii. Just a minor comment about the timeouts: Keep in mind that we actually want to remove timeouts from JUnit tests (see [coding guidelines](https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests)) to benefit...

Closing this one becaue [there are still issues](https://issues.apache.org/jira/browse/FLINK-34324?focusedCommentId=17814891&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17814891).

I addressed my comment, rebased the branch and squashed the commits into a single one.

The test failure is not related to the change: I created FLINK-30236 to cover the timeout issue in the Kafka-related test

I observed the same issue with IntelliJ IDEA 2020.2.4 (Community Edition) Build #IC-202.8194.7, built on November 24, 2020 Runtime version: 11.0.9+11-b944.49 x86_64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o....

> I observed the same issue with IntelliJ IDEA 2020.2.4 (Community Edition) > Build #IC-202.8194.7, built on November 24, 2020 > Runtime version: 11.0.9+11-b944.49 x86_64 > VM: OpenJDK 64-Bit Server...

~I reorganized the PRs. This one is now including FLINK-34047 and the updated FLINK-33906. [This workflow run](https://github.com/XComp/flink/actions/runs/7473830290) includes all the changes and should fail because I haven't set the parameters...

Ok, looks like the CI pipeline is working again: https://github.com/XComp/flink/actions/runs/7475753305/job/20344970380 (the failure in packaging/licensing happened 32019a6f6d7371c0fce23978086324f9583f9534 seems to have been lost in one of the rebasings. I cherry-picked it into...