Hlib Kanunnikov comments

Results 135 comments of


Hlib Kanunnikov

refactor(rpc): move sanity check logic from rpc handlers to implementations.

Yeah, we have some flakiness in tests

[EPIC] e2e: Celestia network tests

This will be resolved with Swamp.

tests(share): enable race detector for reconstruction tests once we migrate to go1.19

As https://github.com/celestiaorg/celestia-node/pull/1067 landed, we can now enable a race detector for those files.

Spec out `ExtendedHeader` and `ExtendedBlock` as data structures for celestia-node

According to recent discussions, the `ExtendedHeader` has to also include `ValidatorSet` and `(Last)Commit`.

chore(deps): bump github.com/libp2p/go-libp2p-peerstore from 0.7.1 to 0.8.0

Will be resolved with https://github.com/celestiaorg/celestia-node/issues/1029

fix: broken shutdown for services on fraud proofs receival

The FraudSyncing test was failing because of https://github.com/celestiaorg/celestia-node/issues/1236. Making the explicit connection light-> full fixed the issue

refactor(params): Moving params to nodebuilder and adding config

I agree that `p2p` is fine also, so let's do this. This might also require changes in the flag names

refactor(params): Moving params to nodebuilder and adding config

@distractedm1nd, conflicts

Further clarify proofs of invalid erasure coding

Do I understand correctly that this is just a spec/docs issue?

all: don't populate protocol ids with chain_id in global space

Code place that needs to be fixed - [ ] HeaderEx: [`header/p2p/service.go`](https://github.com/celestiaorg/celestia-node/blob/main/header/p2p/exchange.go#L29) - [ ] FraudSync: [`fraud/sync`](https://github.com/celestiaorg/celestia-node/blob/main/fraud/service.go#L23)