celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

refactor(rpc): move sanity check logic from rpc handlers to implementations.

Open HoytRen opened this issue 1 year ago • 4 comments

I see only 1 implementation. Tell me if here are more.

Close #998

HoytRen avatar Oct 10 '22 10:10 HoytRen

Codecov Report

Merging #1213 (37b1d8b) into main (18860df) will increase coverage by 0.16%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   55.76%   55.92%   +0.16%     
==========================================
  Files         161      161              
  Lines        9650     9645       -5     
==========================================
+ Hits         5381     5394      +13     
+ Misses       3740     3720      -20     
- Partials      529      531       +2     
Impacted Files Coverage Δ
service/rpc/state.go 0.00% <ø> (ø)
state/core_access.go 12.34% <0.00%> (-0.85%) :arrow_down:
header/core/listener.go 52.83% <0.00%> (-5.67%) :arrow_down:
ipld/get_namespaced_shares.go 88.32% <0.00%> (-2.19%) :arrow_down:
fraud/pb/proof.pb.go 36.61% <0.00%> (+1.89%) :arrow_up:
share/discovery.go 35.41% <0.00%> (+3.12%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 10 '22 10:10 codecov-commenter

Rebased twice, and it still failed...

HoytRen avatar Oct 13 '22 02:10 HoytRen

Yeah, we have some flakiness in tests

Wondertan avatar Oct 13 '22 10:10 Wondertan

happy to see it passed :)

HoytRen avatar Oct 13 '22 13:10 HoytRen