celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

fix: broken shutdown for services on fraud proofs receival

Open distractedm1nd opened this issue 2 years ago • 2 comments

Closes #1205

distractedm1nd avatar Oct 11 '22 14:10 distractedm1nd

Codecov Report

Merging #1220 (2f9b208) into main (738b69f) will decrease coverage by 0.10%. The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
- Coverage   55.64%   55.54%   -0.11%     
==========================================
  Files         160      160              
  Lines        9862     9846      -16     
==========================================
- Hits         5488     5469      -19     
- Misses       3838     3840       +2     
- Partials      536      537       +1     
Impacted Files Coverage Δ
state/core_access.go 13.12% <0.00%> (-0.06%) :arrow_down:
nodebuilder/daser/module.go 88.88% <100.00%> (-0.59%) :arrow_down:
nodebuilder/header/module.go 92.06% <100.00%> (-0.13%) :arrow_down:
nodebuilder/module.go 100.00% <100.00%> (ø)
nodebuilder/p2p/bitswap.go 87.50% <100.00%> (-0.50%) :arrow_down:
nodebuilder/p2p/pubsub.go 68.42% <100.00%> (ø)
nodebuilder/p2p/routing.go 66.66% <100.00%> (ø)
nodebuilder/state/module.go 92.59% <100.00%> (-0.27%) :arrow_down:
share/ipld/get.go 88.88% <0.00%> (-2.67%) :arrow_down:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 12 '22 06:10 codecov-commenter

The FraudSyncing test was failing because of https://github.com/celestiaorg/celestia-node/issues/1236. Making the explicit connection light-> full fixed the issue

Wondertan avatar Oct 14 '22 17:10 Wondertan