Hlib Kanunnikov

Results 135 comments of Hlib Kanunnikov

@liamsi, I made a separate issue out of this. Even though they are related, your comments deserve a separate issue.

https://github.com/celestiaorg/celestia-node/pull/464 relies on the fact that our NMT tree looks like: ``` ---X -X---X X-X-X-X X-X-X-X ``` While one of the points of this issue is to make the tree...

@adlerjohn, it can be avoided. My understanding was that we have to store everything we commit to via nmt.Push, but I missed that we can avoid storing some pieces of...

We need this before incentivized testnet.

The description is now up to date

Implementing the `Head` method for `Syncer` is the original goal of this PR. However, some internal logic has to be changed to allow this, and these logic changes are now...

Nice to have sections: * Context/Background/Goal/Rationale * Changes/Content * TODOs

@iofq, hello, thank you for this PR, and sorry for taking too much time to respond to it. I am super happy to land this. We still need to resolve...

The way https://github.com/filecoin-project/lotus does OpenRPC things: * In-house docsgen: https://github.com/filecoin-project/lotus/tree/master/api/docgen-openrpc * Example of autogenerated docs: https://github.com/filecoin-project/lotus/blob/master/documentation/en/api-v0-methods.md * The way Go clients are "generated" https://github.com/filecoin-project/lotus/blob/master/api/client/client.go. * This is not code generation....