Greg Korba
Greg Korba
I've renamed the issue as it has nothing to do with tests 😉.
I took a brief look on a diff, but mostly I rely on @julienfalque's review here - let's merge 👍.
What's the reasoning behind this PR? Does it fix something? Improves performance? From @keradus' review I see there's potential BC break, but what's the gain?
Thanks for the explanation. PS. That's enough for me today, for bigger reviews I'm out until tomorrow's late afternoon, maybe I can handle small triage or comments during the day.
@mvorisek it's not about what you think, but about @keradus' principles, in this case strict SemVer. There were several occasions when you reported BC breaks for _your_ use cases, this...
I don't see the need for an option here, it's also a "body" - the rule's name does not refer to functions, classes or anything particular, so it can also...
IMHO if PER does not specify that, it means either style is valid and the rule can propose the standard 🙂. If PER specifies it at some point, then it...
Doing more than PER specifies is not a violation, hence the config option is superfluous at this point (nice to have, but not required). Also, such an option should not...
I still think that doing more than described in PER is _not_ against it, it would be if fixer did something that is described as "SHOULD NOT" or "MUST NOT",...
Hi @seb-jean, is this change approved by Symfony maintainers? Or maybe there's some conversation about it? Anyway, as you can see it fails because we still support PHP 7.4 and...