Rik Smale comments

Results 515 comments of


                                            Rik Smale

feat(ci): update build tooling

Thanks for your message! > I also have a few suggestions and topics I’d like to raise. Do you think I should open a dedicated discussion issue for tooling, or...

fix(isHexColor): add `require_hashtag` option

See my comment in https://github.com/validatorjs/validator.js/issues/2533#issuecomment-2739678804 I don't see this becoming the default behaviour, but we could add an option to enforce the use of # prefix

Importing all validation functions into index.js prevents successful treeshaking.

Feel free to open a PR that improves this, while keeping in mind the current tests and that we still support old Node versions

Prevent import * into index.js file so that bundlers can treeshake efficiently.

@Jme797 I'm noticing the test failures in other PRs as well. I think it's a dependency issue, will look into it later

Do not recommend Dependabot configuration over other tools

> In the future, we can check for renovate config before suggesting adding dependabot config. This would be a nice feature to add!