Westbrook Johnson

Results 527 comments of Westbrook Johnson

Questions to answer: - is it safe to run this "flag-customized" version of chromium for all tests? or should you create a group config using it that focuses only on...

So, in the case where Picker leverages this interface, it does so _within_ a Tray. It feels like most use cases would have a specialized approach to closing (whether these...

> I noticed this as a problem in the Menu example for Tray at https://opensource.adobe.com/spectrum-web-components/components/tray/#menu. This makes sense. Thanks for the additional information. For clarity on our end, expanding this...

In lieu of #1719 I'm a bit remiss to say it, but likely the right path here is to update `protected _buttonSelector = 'sp-action-button';` to `protected _buttonSelector = 'sp-action-button, sp-action-menu';`...

This pattern is no longer supported by Spectrum, we should likely deprecate/remove it from the project.

Are you sure that's `Highlight` (#1eebff ish) as opposed to `Spectrum blue` (#2772d8 ish)?

🙈 my bad, misread your comment. Thanks for getting this ticketed! 🙇🏼

Do you find this to be something that would benefit from the `aria-live` attribute and one of its values?

We're not doing much _special_ here, no. I think it's mainly because it's associated to the focused element via `aria-describedby`. So, maybe something more insistent would be useful.