spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[Bug][a11y]: Thumbnail selected state not using Highlight for border color with forced-colors: active

Open majornista opened this issue 1 year ago • 5 comments

Code of conduct

  • [X] I agree to follow this project's code of conduct.

Impacted component(s)

Thumbnail

Expected behavior

Screen shot showing Thumbnail with fixes WHCM
@media (forced-colors: active) {
    :host {
        --spectrum-thumbnail-layer-border-color-outer: CanvasText;
        --spectrum-thumbnail-layer-border-color-inner: Canvas;
        --highcontrast-thumbnail-border-color-selected: Highlight;
    }
}

Actual behavior

The selected Thumbnail state border color does not render using the Highlight color to indicate selection with forced-colors: active.

Notice in the following screen shot how the .layer-inner has outline color remains white, rather than becoming the Canvas color, and the selected style does not use Highlight color with forced-colors: active.

Screen shot showing Thumbnail in WHCM

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

majornista avatar Jun 30 '23 16:06 majornista

@pfulton Can you confirm this in CSS for us?

najikahalsema avatar Oct 26 '23 14:10 najikahalsema

@pfulton Can you confirm this in CSS for us?

Yes, it looks like this is incorrect on our end. Here's how ours renders in forced-colors

Screenshot 2023-10-26 at 1 16 30 PM

pfulton avatar Oct 26 '23 17:10 pfulton

Are you sure that's Highlight (#1eebff ish) as opposed to Spectrum blue (#2772d8 ish)?

Westbrook avatar Oct 26 '23 17:10 Westbrook

To clarify my comment above: it appears that Spectrum CSS hasn't addressed this specific usage at all (hence why I think we see the spectrum blue-ish color), and that it's incorrect on our end, so not just happening within SWC, but also in CSS.

I'll get a ticket in our backlog to address this and get the correct forced-colors experience implemented.

pfulton avatar Oct 26 '23 17:10 pfulton

🙈 my bad, misread your comment. Thanks for getting this ticketed! 🙇🏼

Westbrook avatar Oct 26 '23 18:10 Westbrook

fixed via spectrum-css/#2254

najikahalsema avatar Aug 07 '24 16:08 najikahalsema