spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[Bug][ally]: Banner add border in WHCM/forced-colors: active

Open majornista opened this issue 1 year ago • 2 comments

Code of conduct

  • [X] I agree to follow this project's code of conduct.

Impacted component(s)

Banner

Expected behavior

Banner should have a border when its background-color is replaced with canvas color in Windows High Contrast Mode/forced-colors: active, so that it can be distinguished from other content.

Actual behavior

Banner lacks a border when its background-color is replaced with canvas color in Windows High Contrast Mode/forced-colors: active.

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

majornista avatar Jun 21 '23 15:06 majornista

This pattern is no longer supported by Spectrum, we should likely deprecate/remove it from the project.

Westbrook avatar Jun 22 '23 13:06 Westbrook

We should come up with a process for deprecation. How do we want to let users know when something is being deprecated, and when do we want to remove the code marked for deprecation? @Rajdeepc @jnjosh

najikahalsema avatar Oct 05 '23 15:10 najikahalsema

Banner is in process of deprecation as in #4176 . We will close this bug once the PR is merged.

Rajdeepc avatar Mar 14 '24 09:03 Rajdeepc

Closing this as part of #4176

Rajdeepc avatar Mar 21 '24 09:03 Rajdeepc