Wedge009
Wedge009
I'm not familiar with the warning, but it seems related to the declaration of the `update_label_` variables in the respective class/struct vs the order in which they're initialised in the...
I think similarly to #8662, there are cases where integer overflow occurs that aren't handled well or at all, but the consequences for the overflow are not crippling. I presume...
> I think there is an issue somewhere that the chat should be scrolled to the bottom. So this is a duplicate and/or an elaboration of #1290?
I found it was sufficient just to go through the end credits for EI. I can confirm the issue no longer occurs, at least for the text that I observed.
Thanks for reviewing all of these issues. Overall it seems reasonable to me. > I also noticed #8504 and I wonder whether Chamber of Death in 05a_01 should be removed,...
What's outstanding on this? Is it just the positioning of an event and whether or not #8584 is actually addressed? I note Dalas has already approved this.
Would be a shame for the effort here not to be merged. What's actually outstanding and can we fix this ourselves, if @Earth-Cake is no longer around?
It looks like: 1. Addresses #8493. 2. Addresses #8499. 3. Addresses #8501. 4. Tries to address #8584. 5. Tries to address #8586. 6. Additions to commit 1 and 4/5.
Cherry-picked into #9875.
So commit 5 okay, but not commit 4 or 6b?