Vincent Langlet

> https://github.com/paysera/lib-pagination > What do you think about it? We won't add a dependency to a low maintenance library, but > You can fix such issues with cursor based pagination:...

This would be great ; with https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/6466, it will close https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5026

> Given the discussions, I would say that PSR-12 intended to enforce parentheses even without arguments, but provided examples inconsistent with that rule. I propose to keep `@PSR12` unchanged. Then...

I think this PR would closes https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/4491

Isn't a duplicate of https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/2814 ?

Currently the default value is set here: https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/1f8791e08852365aeb2849fc10d878a121970e01/src/Filter/DateTimeRangeFilter.php#L36 This could be conditional bases on a config indeed. The config option would be passed in the construct of https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/1f8791e08852365aeb2849fc10d878a121970e01/src/Filter/AbstractDateFilter.php#L26 ``` public...

> Shouldn't the PR be in Admin Bundle instead/too? Or are these currently ignored? > > Otherwise i don't understand why ORM Bundle is overwriting the field_type when AdminBundle is...

> i meant it for DateTimeRangeFilter, AbstractDateFilter sets this: https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/4.x/src/Filter/AbstractDateFilter.php#L108 > > which sets the field_type there: https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Form/Type/Filter/DateTimeRangeType.php#L41 > > should in these classes also a "picker" parameter added? Indeed...

> the problem i currently have is this: https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Filter/Filter.php#L176 > > i wanted to make > > ``` > public function getDefaultOptions(): array > { > return ['field_type' => DateTimeRangeType::class];...

> i added an MR for SonataAdminBundle to add picker as option to the Form Filter I added a comment. I don't think you understood me because I was talking...