Vincent Langlet

Results 395 comments of Vincent Langlet

No problem. I merged the PR to test more easily. I'll try it on some projects. I'll also maybe change the default value `useQuote` from true to false before releasing...

Released in 2.9.0

Hi @franmomu, what about following the same strategy than https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/4.x/.github/workflows/test_orm_3.yaml ? gedmo/doctrine-extensions is an optional dev dependency, it should be a blocker for the ORM 3 support.

> Perhaps we should throw an `Exception` if calling the validate method using an unsupported country code prefix? This would require a new major version since it's a BC break....

So far you can do https://phpstan.org/r/6c18d3d3-e29c-41aa-b628-d826286859ec @colorvamp

The only error I get now is coming from the test https://github.com/vimeo/psalm/pull/10927/files/91ea61e4170656cb7a54347271d054e9037106d6#diff-19d1ea03f9fa43528c7190e1c91a6a4f216c48b742e3e2dcdd4e75e750c6a7a5 But this failure also happen in 5.x as soon as I fix the phpdoc of the tests https://github.com/vimeo/psalm/pull/10929...

Hi @janedbal, I need this PR to move on mine https://github.com/phpstan/phpstan-doctrine/pull/520. What is missing here (maybe writing tests ?) ; do you need help ?

> @VincentLanglet Jan already drowned dozens of hours to get this right, it's a very complex topic as you can see in here [janedbal/php-database-drivers-fetch-test](https://github.com/janedbal/php-database-drivers-fetch-test/). Don't rush this :) Sorry if...

> @VincentLanglet Pushed the WIP so that you can check the direction I'm leaning towards. Thanks, can I help you on this ? If I understand correctly the goal is...

> @VincentLanglet I've some stuff in backlog to do first before returning to this. But the outline what needs to be done: > > * (1) Decide how to deal...