Vincent Langlet

Results 395 comments of Vincent Langlet

@alexzherdev Since my PR https://github.com/yannickcr/eslint-plugin-react/pull/2182 was merged, you have to update the new sort-default-props, or you'll lose the fix I made. Thanks ;)

> Fairly sure that since it's in a conditional, it does not get scanned at all by `roave/better-reflection`: potentially to be tested with a `StringSourceLocator` I know nothing about the...

it should even be the default behaviour.

> -1 for being the default behavior. That would make it a lot harder to identify mistakes (typo in a property name) when you don't expect it to be optional....

> Well, first, it does _not_ throw an exception by default in production, as `strict_variables` is opt-in and will make `.` return `null` for non-existent attributes. > > If what...

Friendly ping @fabpot, would it be possible to have more information about the coding standard of twig about naming ? I'll be happy to provide a PR to improve the...

According to the phpdoc https://github.com/sebastianbergmann/phpunit/blob/adeede29ca716930efb49ebe0fe1a5cab38af9c4/src/Framework/Assert.php#L95 ArrayAccess has to be supported too indeed. Can you provide a fix @micheh ?

HI @mvorisek, with this change, I have some float comparison which are failing. Basically with some things like ``` $this->assertEquals(0.3, 0.1+0.2); ``` Wouldn't be useful to provide the old implementation...

I just encountered this issue with the code ``` $object2 = $this->getMockBuilder(\stdClass::class)->addMethods(['addFooBar'])->getMock(); $object2->expects($this->once())->method('addFooBar')->with($instance); ``` Any recommendation @ondrejmirtes ?

I created a reproducer: https://github.com/phpstan/phpstan-phpunit/pull/93